Bump ORA version to 0.2.7. #11429
Bump ORA version to 0.2.7. #11429
Conversation
| @@ -78,7 +78,7 @@ git+https://github.com/edx/XBlock.git@xblock-0.4.4#egg=XBlock==0.4.4 | |||
| -e git+https://github.com/edx/event-tracking.git@0.2.1#egg=event-tracking==0.2.1 | |||
| -e git+https://github.com/edx/django-splash.git@v0.2#egg=django-splash==0.2 | |||
| -e git+https://github.com/edx/acid-block.git@e46f9cda8a03e121a00c7e347084d142d22ebfb7#egg=acid-xblock | |||
| -e git+https://github.com/edx/edx-ora2.git@0.2.6#egg=ora2==0.2.6 | |||
| -e git+https://github.com/edx/edx-ora2.git@0.2.7#egg=ora2==0.2.7 | |||
There was a problem hiding this comment.
Now would be a fine time to remove the -e.
There was a problem hiding this comment.
@nedbat
What does it mean to remove the "-e"? Why was it there before, and why do we no longer need it?
There was a problem hiding this comment.
The -e means, install as an editable working tree. We never needed it, it's been cargo-culted from the beginning. It's allowed us to have bugs in our setup.py files that we don't find until much later.
The instructions at the top of the file were an attempt to get people to stop using it. :)
There was a problem hiding this comment.
@nedbat thanks. I would think you knew by now that nobody reads the instructions at the top of the file (unless the thing they are changing is at the top of the file). :)
|
jenkins run bokchoy |
cahrens
force-pushed
the
christina/ora-release
branch
from
dc8152b
to
0a900cf
Compare
|
The test failures are because of the errors in ora's setup.py: it doesn't name all of the packages that it should. |
|
Thanks, @nedbat. So does ora2 need to declare EVERY package it has? Is there no concept of "private" packages? For instance, there is an init file in openassessment/assessment/migrations, but it seems odd to declare that as a package. |
cahrens
force-pushed
the
christina/ora-release
branch
from
b269cad
to
0a900cf
Compare
|
If you want the code to be installed when the kit is installed, then it needs to be in the packages list. That's all that list is for: what packages are in the kit, and need to be copied during installation. Many people avoid an explicit list of packages by doing this: Some people exclude certain packages, but there it isn't required. |
|
jenkins run lettuce |
cahrens
force-pushed
the
christina/ora-release
branch
from
0a900cf
to
4c93835
Compare
|
jenkins run bokchoy |
No description provided.